Get rid of Group, with the intention that the groups library is used instead #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
no-group
branch
3 times, most recently
from
b7381af
to
2aaae42
Compare
Ericson2314
changed the title
|
Let's see where things actually break without that orphan instance - maybe we can remove reliance on it entirely. |
Ericson2314
force-pushed
the
no-group
branch
from
2aaae42
to
6be4716
Compare
Ericson2314
changed the title
Keep `Additive`, however. See ChangeLog for more details. The version in the cabal file is bumped to remind whoever does the future release that this is breaking change. Closes #4.
It turns out we were relying on instances from a transitive dependency on base-orphans. Added that explicitly so that we don't regress on the instances provided with old GHCs.
Ericson2314
force-pushed
the
no-group
branch
from
6335a25
to
57bdb25
Compare
Ericson2314
commented
Dec 12, 2020
patch.cabal
Outdated
Comment on lines
42
to
43
| if impl(ghc < 8.6) -- really, if base < 8.12 | ||
| build-depends: base-orphans >= 0.8 && < 0.9 |
There was a problem hiding this comment.
We could get rid of this, and just not provide :.: and :*: Additive instances before GHC 8.6. I don't care which.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See change log, this does depend on #4 being resolved first, and possibly other issues.